fix timezone bug when persisting *gtime.Time to db #1714

[wesleywu]

No description provided.

[codecov-commenter]

Codecov Report

Merging #1729 (1a271ce) into master (52d8371) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
- Coverage   71.27%   71.27%   -0.01%     
==========================================
  Files         452      452              
  Lines       43310    43310              
==========================================
- Hits        30869    30868       -1     
- Misses      10466    10469       +3     
+ Partials     1975     1973       -2     

Flag	Coverage Δ
go-1.15	71.24% <100.00%> (-0.01%)	⬇️
go-1.16	71.23% <100.00%> (+<0.01%)	⬆️
go-1.17	71.23% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
database/gdb/gdb_func.go	86.15% <100.00%> (ø)
os/gspath/gspath_cache.go	87.71% <0.00%> (-7.02%)	⬇️
os/glog/glog_logger_rotate.go	67.31% <0.00%> (ø)
database/gdb/gdb_driver_mysql.go	64.86% <0.00%> (+2.70%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d8371...1a271ce. Read the comment docs.

[gqcn]

@wesleywu If you need auto time converting feature of underlying driver, please use time.Time instead of gtime.Time.

[wesleywu]

@wesleywu If you need auto time converting feature of underlying driver, please use time.Time instead of gtime.Time.
@gqcn
If I use *time.Time for columns, I could not retrieve them right because issue #1727.
Not considering to use time.Time because I need to check if column value is nil.

Thanks.

[wesleywu]

@wesleywu If you need auto time converting feature of underlying driver, please use time.Time instead of gtime.Time.

@gqcn
And I don't think I'm using any auto time conversion because my fix did not do any conversion, which should be expected behavior for db persisting. On the contrary, the original implementation used time conversion by calling gtime.Time.String().

[wesleywu]

the gtime.Time.String() method is flawed because it loses timezone info.