Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1965 #2177

Merged
merged 1 commit into from
Oct 8, 2022
Merged

fix issue #1965 #2177

merged 1 commit into from
Oct 8, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Oct 8, 2022

No UT case added.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Base: 76.49% // Head: 76.50% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (818ec28) compared to base (d7ae562).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
+ Coverage   76.49%   76.50%   +0.01%     
==========================================
  Files         580      580              
  Lines       48103    48102       -1     
==========================================
+ Hits        36795    36801       +6     
+ Misses       9292     9287       -5     
+ Partials     2016     2014       -2     
Flag Coverage Δ
go-1.15-386 76.50% <100.00%> (+<0.01%) ⬆️
go-1.15-amd64 76.51% <100.00%> (+0.01%) ⬆️
go-1.16-386 76.51% <100.00%> (+0.01%) ⬆️
go-1.16-amd64 76.54% <100.00%> (+0.05%) ⬆️
go-1.17-386 76.52% <100.00%> (+<0.01%) ⬆️
go-1.17-amd64 76.52% <100.00%> (+0.03%) ⬆️
go-1.18-386 76.44% <100.00%> (+<0.01%) ⬆️
go-1.18-amd64 76.45% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_model_utility.go 81.87% <ø> (-0.45%) ⬇️
database/gdb/gdb_driver_wrapper_db.go 100.00% <100.00%> (ø)
os/gfile/gfile_scan.go 90.00% <0.00%> (+7.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 7cb5fbe into master Oct 8, 2022
@gqcn gqcn deleted the fix/1965 branch October 8, 2022 13:42
houseme added a commit to houseme/gf that referenced this pull request Oct 13, 2022
* master: (29 commits)
  fix issue gogf#1946 (gogf#2194)
  fix issue of OmitEmptyWhere in Builder for package gdb (gogf#2195)
  fix: modify `Polaris` config readme.md (gogf#2186)
  fix info content when listens on port :0 for ghttp.Server (gogf#2191)
  fix: pgsql driver check local type error (gogf#2192)
  new version v2.2.0 (gogf#2185)
  feat: temporarily disable the unit testing of the Polaris configuration center (gogf#2183)
  package comments and readme update (gogf#2182)
  feat: create polaris config (gogf#2170)
  add function `ZipPathContent` for package `gcompress` (gogf#2179)
  feat: improve glog for polaris  register (gogf#2178)
  improve port listening for ghttp.Server (gogf#2175)
  add WithUUID for package gtrace (gogf#2176)
  fix issue gogf#1965 (gogf#2177)
  fix issue gogf#1965 (gogf#2174)
  fix issue gogf#2172 (gogf#2173)
  add `gcfg.Adapter` implements using apollo service (gogf#2165)
  add watch feature for package kubecm (gogf#2164)
  fix configuration management for package gdb (gogf#2163)
  add local db configuration support for package gdb (gogf#2161)
  ...

# Conflicts:
#	contrib/config/apollo/README.MD
#	contrib/config/apollo/apollo.go
#	contrib/config/kubecm/README.MD
#	contrib/config/kubecm/kubecm.go
#	contrib/drivers/README.MD
#	contrib/registry/polaris/go.mod
#	contrib/registry/polaris/go.sum
#	database/gdb/gdb_driver_wrapper_db.go
#	example/go.mod
#	example/go.sum
#	version.go
houseme pushed a commit that referenced this pull request Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants