Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove repeated error stack file lines among stacks for package gerror #2199

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Oct 13, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 76.52% // Head: 76.54% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (d6dff2a) compared to base (5efa5eb).
Patch coverage: 93.40% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
+ Coverage   76.52%   76.54%   +0.02%     
==========================================
  Files         580      580              
  Lines       48186    48240      +54     
==========================================
+ Hits        36872    36926      +54     
  Misses       9292     9292              
  Partials     2022     2022              
Flag Coverage Δ
go-1.15-386 76.52% <93.40%> (-0.03%) ⬇️
go-1.15-amd64 76.58% <93.40%> (+0.07%) ⬆️
go-1.16-386 76.57% <93.40%> (+0.04%) ⬆️
go-1.16-amd64 76.57% <93.40%> (+0.04%) ⬆️
go-1.17-386 76.60% <93.40%> (+0.08%) ⬆️
go-1.17-amd64 76.58% <93.40%> (+0.04%) ⬆️
go-1.18-386 76.46% <93.40%> (-0.01%) ⬇️
go-1.18-amd64 76.50% <93.40%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
errors/gerror/gerror_error_format.go 66.66% <ø> (-8.85%) ⬇️
errors/gerror/gerror_error_stack.go 88.88% <93.40%> (+14.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 55e8dbe into master Oct 13, 2022
@gqcn gqcn deleted the enhance/gerror-stack branch October 13, 2022 11:12
houseme pushed a commit that referenced this pull request Oct 22, 2022
#2199)

* remove repeated error stack file lines among stacks for package gerror

* fix nil pointer error for package gerror
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants