Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach and export real handler for request #2220

Merged
merged 6 commits into from
Nov 1, 2022
Merged

attach and export real handler for request #2220

merged 6 commits into from
Nov 1, 2022

Conversation

SUDOCS
Copy link
Contributor

@SUDOCS SUDOCS commented Oct 18, 2022

record user defined handler to request object before executing middlewares, which makes it possible to do something special according to the final target router in handler.

#2217

net/ghttp/ghttp.go Outdated Show resolved Hide resolved
@gqcn gqcn added the awesome It's awesome! We keep watching. label Oct 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 76.57% // Head: 76.50% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (fd0d00a) compared to base (8e0e878).
Patch coverage: 76.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2220      +/-   ##
==========================================
- Coverage   76.57%   76.50%   -0.07%     
==========================================
  Files         580      582       +2     
  Lines       48281    48404     +123     
==========================================
+ Hits        36969    37033      +64     
- Misses       9290     9341      +51     
- Partials     2022     2030       +8     
Flag Coverage Δ
go-1.15-386 76.49% <76.47%> (?)
go-1.15-amd64 76.50% <76.47%> (-0.03%) ⬇️
go-1.16-386 76.49% <76.47%> (-0.03%) ⬇️
go-1.16-amd64 76.54% <76.47%> (+0.04%) ⬆️
go-1.17-386 76.52% <76.47%> (+<0.01%) ⬆️
go-1.17-amd64 76.54% <76.47%> (?)
go-1.18-386 76.47% <76.47%> (?)
go-1.18-amd64 76.43% <76.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp.go 100.00% <ø> (ø)
net/ghttp/ghttp_request.go 83.45% <0.00%> (-1.28%) ⬇️
net/ghttp/ghttp_server_router_serve.go 76.92% <81.81%> (+0.12%) ⬆️
net/ghttp/ghttp_request_middleware.go 82.72% <100.00%> (ø)
net/ghttp/ghttp_server_handler.go 63.60% <100.00%> (ø)
net/ghttp/ghttp_server_router_hook.go 92.75% <100.00%> (ø)
contrib/config/kubecm/kubecm.go 38.38% <0.00%> (ø)
contrib/config/kubecm/kubecm_kube.go 100.00% <0.00%> (ø)
os/gcache/gcache_adapter_memory_lru.go 97.82% <0.00%> (+8.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SUDOCS SUDOCS requested a review from gqcn October 28, 2022 03:31
@gqcn gqcn merged commit 63c3e83 into gogf:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome It's awesome! We keep watching.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants