Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve nil receiver handling for package gtime #2226

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Oct 21, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 76.54% // Head: 76.55% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (70c7ad2) compared to base (33fdde6).
Patch coverage: 31.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
+ Coverage   76.54%   76.55%   +0.01%     
==========================================
  Files         581      581              
  Lines       48318    48335      +17     
==========================================
+ Hits        36983    37001      +18     
- Misses       9312     9314       +2     
+ Partials     2023     2020       -3     
Flag Coverage Δ
go-1.15-386 76.57% <31.57%> (?)
go-1.15-amd64 76.58% <31.57%> (?)
go-1.16-386 76.57% <31.57%> (?)
go-1.16-amd64 76.56% <31.57%> (?)
go-1.17-386 76.57% <31.57%> (?)
go-1.17-amd64 76.57% <31.57%> (-0.02%) ⬇️
go-1.18-386 76.49% <31.57%> (-0.02%) ⬇️
go-1.18-amd64 76.48% <31.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gtime/gtime_time.go 81.56% <31.57%> (-4.15%) ⬇️
container/gtree/gtree_avltree.go 95.97% <0.00%> (+0.57%) ⬆️
os/glog/glog_logger_rotate.go 64.70% <0.00%> (+1.35%) ⬆️
os/gspath/gspath_cache.go 94.73% <0.00%> (+7.01%) ⬆️
os/gcache/gcache_adapter_memory_lru.go 97.82% <0.00%> (+8.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 425b31c into master Oct 26, 2022
@gqcn gqcn deleted the enhance/gtime-nil branch October 26, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants