Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseConfigNodeLink support Chinese database name #2231 #2238

Merged
merged 11 commits into from
Dec 22, 2022

Conversation

sanrentai
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 78.17% // Head: 78.15% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (3dcb5de) compared to base (14d2d74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2238      +/-   ##
==========================================
- Coverage   78.17%   78.15%   -0.03%     
==========================================
  Files         584      584              
  Lines       48535    48535              
==========================================
- Hits        37942    37932      -10     
- Misses       8579     8585       +6     
- Partials     2014     2018       +4     
Flag Coverage Δ
go-1.15-386 78.18% <ø> (+<0.01%) ⬆️
go-1.15-amd64 78.18% <ø> (+0.02%) ⬆️
go-1.16-386 78.18% <ø> (-0.03%) ⬇️
go-1.16-amd64 78.17% <ø> (+<0.01%) ⬆️
go-1.17-386 78.17% <ø> (-0.02%) ⬇️
go-1.17-amd64 78.18% <ø> (-0.02%) ⬇️
go-1.18-386 78.10% <ø> (-0.01%) ⬇️
go-1.18-amd64 78.09% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb.go 68.34% <ø> (ø)
os/gcache/gcache_adapter_memory_lru.go 89.13% <0.00%> (-8.70%) ⬇️
os/gfpool/gfpool_file.go 65.71% <0.00%> (-2.86%) ⬇️
os/gfsnotify/gfsnotify_watcher_loop.go 83.19% <0.00%> (-1.69%) ⬇️
os/glog/glog_logger_rotate.go 63.34% <0.00%> (-1.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

database/gdb/gdb.go Outdated Show resolved Hide resolved
@sanrentai sanrentai requested a review from gqcn November 10, 2022 09:33
@sanrentai sanrentai marked this pull request as draft November 10, 2022 09:34
@sanrentai sanrentai marked this pull request as ready for review November 11, 2022 02:06
@gqcn gqcn merged commit e007bf3 into gogf:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants