Update gutil_dump.go

[brick-carrier-fan]

Solve the panic: reflect: call of reflect.Value.Type on zero Value [recovered] The reason for this is the circular reference itself

[brick-carrier-fan]

it likes

type Abc struct {
		ab int
		//bc BC
		cd *Abc
	}
	
	abc := Abc{ab: 3}
	abc.cd = &abc
	g.Dump(abc)

output:
panic: reflect: call of reflect.Value.Type on zero Value

[gqcn]

It may check the reflectValue at line 107:

// Double check nil value.
if value == nil || reflectValue.IsNil() || !reflectValue.IsValid() {
	buffer.WriteString(`<nil>`)
	return
}

[brick-carrier-fan]

I've tried your way of checking the reflectValue, and it brings the same mistake.
Not available to check reflectValue with IsNil().
The method I submitted is available.
I apologize for my poor English.

[gqcn]

@brick-carrier-fan OK, then try this:

// Double check nil value.
if value == nil || !reflectValue.IsValid() || (reflectValue.Kind() == reflect.Ptr && reflectValue.IsNil()) {
	buffer.WriteString(`<nil>`)
	return
}

[brick-carrier-fan]

Yes,buffer will go to get infinitely bigger,then get OOM panic

[gqcn]

Yes,buffer will go to get infinitely bigger,then get OOM panic

Any question carrying on this PR?

[gqcn]

@brick-carrier-fan Please add UT case for this issue, too.

[codecov-commenter]

Codecov Report

Base: 78.17% // Head: 78.15% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (126ccb9) compared to base (14d2d74).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
- Coverage   78.17%   78.15%   -0.02%     
==========================================
  Files         584      584              
  Lines       48535    48538       +3     
==========================================
- Hits        37942    37937       -5     
- Misses       8579     8584       +5     
- Partials     2014     2017       +3     

Flag	Coverage Δ
go-1.15-386	78.15% <100.00%> (-0.02%)	⬇️
go-1.15-amd64	78.18% <100.00%> (+0.02%)	⬆️
go-1.16-386	78.19% <100.00%> (-0.02%)	⬇️
go-1.16-amd64	78.16% <100.00%> (-0.01%)	⬇️
go-1.17-386	78.16% <100.00%> (-0.04%)	⬇️
go-1.17-amd64	78.18% <100.00%> (-0.02%)	⬇️
go-1.18-386	78.07% <100.00%> (-0.04%)	⬇️
go-1.18-amd64	78.12% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
util/gutil/gutil_dump.go	91.95% <100.00%> (+0.07%)	⬆️
os/gcache/gcache_adapter_memory_lru.go	89.13% <0.00%> (-8.70%)	⬇️
os/gfpool/gfpool_file.go	65.71% <0.00%> (-2.86%)	⬇️
os/glog/glog_logger_rotate.go	63.34% <0.00%> (-1.36%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[gqcn]

@brick-carrier-fan OK, then try this:

// Double check nil value.
if value == nil || !reflectValue.IsValid() || (reflectValue.Kind() == reflect.Ptr && reflectValue.IsNil()) {
	buffer.WriteString(`<nil>`)
	return
}

[gqcn]

Yes,buffer will go to get infinitely bigger,then get OOM panic

Any question carrying on this PR?

[gqcn]

@brick-carrier-fan I fix this in #2367