Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fixed An error occurred when only one file was uploaded in batches and add unit testing(#2092) #2357

Closed
wants to merge 1 commit into from

Conversation

tiger1103
Copy link
Contributor

修复规范路由下批量上传时,若只上传一个文件出现错误:reflect.Value.Convert: value of type *ghttp.UploadFile cannot be converted to type ghttp.UploadFile
修复前单测:
image
修复后:
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Base: 79.55% // Head: 79.61% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (a7f7259) compared to base (b0c9c68).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
+ Coverage   79.55%   79.61%   +0.05%     
==========================================
  Files         589      589              
  Lines       48803    48803              
==========================================
+ Hits        38825    38853      +28     
+ Misses       8004     7984      -20     
+ Partials     1974     1966       -8     
Flag Coverage Δ
go-1.15-386 79.60% <100.00%> (+<0.01%) ⬆️
go-1.15-amd64 79.64% <100.00%> (+0.09%) ⬆️
go-1.16-386 79.63% <100.00%> (+0.03%) ⬆️
go-1.16-amd64 79.65% <100.00%> (+0.09%) ⬆️
go-1.17-386 79.61% <100.00%> (+0.02%) ⬆️
go-1.17-amd64 79.63% <100.00%> (+0.05%) ⬆️
go-1.18-386 79.58% <100.00%> (+0.06%) ⬆️
go-1.18-amd64 79.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp_request_param_request.go 90.16% <100.00%> (+2.45%) ⬆️
os/glog/glog_logger_rotate.go 64.70% <0.00%> (+1.35%) ⬆️
util/gconv/gconv_struct.go 81.01% <0.00%> (+3.24%) ⬆️
os/gfsnotify/gfsnotify_watcher_loop.go 84.87% <0.00%> (+6.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn added the awesome It's awesome! We keep watching. label Dec 20, 2022
@gqcn
Copy link
Member

gqcn commented Dec 20, 2022

@tiger1103 你好,感谢贡献!不过这里的问题主要出在转换组件那里,因此我新开了一个分支,合并了你的代码,并做了些改动提交了新的PR:#2365

@gqcn gqcn closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome It's awesome! We keep watching.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants