Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Unknown setting charset for clickhouse driver #2375

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Dec 27, 2022

No description provided.

@gqcn gqcn added the bug It is confirmed a bug, but don't worry, we'll handle it. label Dec 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Base: 79.82% // Head: 79.84% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (56ec7ef) compared to base (0876e00).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2375      +/-   ##
==========================================
+ Coverage   79.82%   79.84%   +0.01%     
==========================================
  Files         589      589              
  Lines       48836    48836              
==========================================
+ Hits        38984    38991       +7     
+ Misses       7870     7862       -8     
- Partials     1982     1983       +1     
Flag Coverage Δ
go-1.15-386 79.89% <50.00%> (+0.01%) ⬆️
go-1.15-amd64 79.89% <50.00%> (+0.02%) ⬆️
go-1.16-386 79.89% <50.00%> (+0.03%) ⬆️
go-1.16-amd64 79.86% <50.00%> (-0.01%) ⬇️
go-1.17-386 79.87% <50.00%> (+0.01%) ⬆️
go-1.17-amd64 79.88% <50.00%> (-0.01%) ⬇️
go-1.18-386 79.82% <50.00%> (+0.02%) ⬆️
go-1.18-amd64 79.81% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/clickhouse/clickhouse.go 73.82% <50.00%> (ø)
os/gfpool/gfpool_file.go 68.57% <0.00%> (+2.85%) ⬆️
os/gfsnotify/gfsnotify_watcher_loop.go 83.19% <0.00%> (+5.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 0266d24 into master Dec 27, 2022
@gqcn gqcn deleted the fix/ch-charset branch December 27, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It is confirmed a bug, but don't worry, we'll handle it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants