Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 2391 #2398

Merged
merged 4 commits into from
Jan 16, 2023
Merged

fix issue 2391 #2398

merged 4 commits into from
Jan 16, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Jan 16, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Base: 79.61% // Head: 79.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9fc2890) compared to base (6ff4ed8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2398   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files         598      598           
  Lines       49685    49685           
=======================================
+ Hits        39555    39559    +4     
+ Misses       8132     8129    -3     
+ Partials     1998     1997    -1     
Flag Coverage Δ
go-1.15-386 79.68% <100.00%> (+0.04%) ⬆️
go-1.15-amd64 79.67% <100.00%> (+0.05%) ⬆️
go-1.16-386 79.67% <100.00%> (+0.05%) ⬆️
go-1.16-amd64 79.65% <100.00%> (+0.01%) ⬆️
go-1.17-386 79.67% <100.00%> (+0.02%) ⬆️
go-1.17-amd64 79.68% <100.00%> (+0.07%) ⬆️
go-1.18-386 79.55% <100.00%> (-0.02%) ⬇️
go-1.18-amd64 79.60% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/gconv/gconv_map.go 97.05% <100.00%> (+0.49%) ⬆️
contrib/registry/zookeeper/zookeeper_watcher.go 51.11% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 3f6669e into master Jan 16, 2023
@gqcn gqcn deleted the fix/2391 branch January 16, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants