Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve unit testing cases coverage to 80%+ #2480

Merged
merged 15 commits into from
Mar 7, 2023
Merged

improve unit testing cases coverage to 80%+ #2480

merged 15 commits into from
Mar 7, 2023

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Feb 28, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15 🎉

Comparison is base (34946f6) 79.96% compared to head (52dade5) 80.12%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2480      +/-   ##
==========================================
+ Coverage   79.96%   80.12%   +0.15%     
==========================================
  Files         598      599       +1     
  Lines       49570    49789     +219     
==========================================
+ Hits        39641    39891     +250     
+ Misses       7984     7956      -28     
+ Partials     1945     1942       -3     
Flag Coverage Δ
go-1.15-386 80.17% <100.00%> (+0.13%) ⬆️
go-1.15-amd64 80.18% <100.00%> (?)
go-1.16-386 80.18% <100.00%> (+0.16%) ⬆️
go-1.16-amd64 80.16% <100.00%> (+0.17%) ⬆️
go-1.17-386 80.17% <100.00%> (?)
go-1.17-amd64 80.17% <100.00%> (?)
go-1.18-386 80.09% <100.00%> (+0.16%) ⬆️
go-1.18-amd64 80.08% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
text/gstr/gstr_parse.go 95.34% <100.00%> (+50.38%) ⬆️
contrib/drivers/oracle/oracle.go 79.45% <0.00%> (ø)
os/gfsnotify/gfsnotify_watcher_loop.go 87.39% <0.00%> (+9.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hailaz hailaz changed the title improve unit testing cases improve unit testing cases coverage to 80%+ Feb 28, 2023
text/gstr/gstr_parse.go Show resolved Hide resolved
@gqcn gqcn added wip awesome It's awesome! We keep watching. labels Mar 1, 2023
text/gstr/gstr_parse.go Show resolved Hide resolved
@hailaz hailaz added done This issue is done, which may be release in next version. and removed wip labels Mar 7, 2023
@gqcn gqcn merged commit 55690f3 into master Mar 7, 2023
@gqcn gqcn deleted the fix/unit_test branch March 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome It's awesome! We keep watching. done This issue is done, which may be release in next version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants