Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in empty json name along with omitempty tag in package oai #2500

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Mar 7, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.01 ⚠️

Comparison is base (d0d41a6) 79.97% compared to head (7d4c951) 79.97%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2500      +/-   ##
==========================================
- Coverage   79.97%   79.97%   -0.01%     
==========================================
  Files         599      599              
  Lines       49789    49795       +6     
==========================================
+ Hits        39821    39824       +3     
- Misses       8010     8012       +2     
- Partials     1958     1959       +1     
Flag Coverage Δ
go-1.15-386 80.02% <62.50%> (+0.02%) ⬆️
go-1.15-amd64 80.01% <62.50%> (-0.02%) ⬇️
go-1.16-386 80.03% <62.50%> (+0.01%) ⬆️
go-1.16-amd64 80.01% <62.50%> (+<0.01%) ⬆️
go-1.17-386 79.98% <62.50%> (-0.03%) ⬇️
go-1.17-amd64 80.03% <62.50%> (+0.03%) ⬆️
go-1.18-386 79.93% <62.50%> (-0.01%) ⬇️
go-1.18-amd64 79.93% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/goai/goai_parameter_ref.go 77.77% <25.00%> (-3.89%) ⬇️
net/goai/goai_shema.go 71.91% <100.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit e8051ba into master Mar 7, 2023
@gqcn gqcn deleted the fix/omitempty-in-goai branch March 7, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants