Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http context never done #2602

Merged
merged 5 commits into from
Apr 26, 2023
Merged

http context never done #2602

merged 5 commits into from
Apr 26, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Apr 25, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (a9090e4) 78.85% compared to head (ea8af78) 78.86%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2602   +/-   ##
=======================================
  Coverage   78.85%   78.86%           
=======================================
  Files         631      631           
  Lines       51596    51607   +11     
=======================================
+ Hits        40687    40698   +11     
- Misses       8895     8899    +4     
+ Partials     2014     2010    -4     
Flag Coverage Δ
go-1.15-386 78.90% <50.00%> (+0.01%) ⬆️
go-1.15-amd64 78.87% <50.00%> (-0.01%) ⬇️
go-1.16-386 78.88% <50.00%> (-0.01%) ⬇️
go-1.16-amd64 78.86% <50.00%> (-0.03%) ⬇️
go-1.17-386 78.89% <50.00%> (+0.01%) ⬆️
go-1.17-amd64 ?
go-1.18-386 78.81% <50.00%> (+0.01%) ⬆️
go-1.18-amd64 78.82% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp_request_param_ctx.go 83.33% <50.00%> (-16.67%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 4c6ebe7 into master Apr 26, 2023
@gqcn gqcn deleted the enhance/context-never-done branch April 26, 2023 12:20
dukepan2005 pushed a commit to dukepan2005/gf that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants