Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change parameter prefix of type string to prefixes of type slice for command enums #2662

Merged
merged 4 commits into from
May 24, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented May 23, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (05ee4d4) 78.83% compared to head (53d2a55) 78.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2662      +/-   ##
==========================================
- Coverage   78.83%   78.81%   -0.02%     
==========================================
  Files         631      631              
  Lines       51715    51723       +8     
==========================================
- Hits        40770    40767       -3     
- Misses       8924     8935      +11     
  Partials     2021     2021              
Flag Coverage Δ
go-1.15-386 78.84% <0.00%> (-0.03%) ⬇️
go-1.15-amd64 78.83% <0.00%> (+0.04%) ⬆️
go-1.16-386 ?
go-1.16-amd64 78.84% <0.00%> (+<0.01%) ⬆️
go-1.17-386 78.85% <0.00%> (-0.02%) ⬇️
go-1.17-amd64 78.84% <0.00%> (-0.01%) ⬇️
go-1.18-386 78.79% <0.00%> (+<0.01%) ⬆️
go-1.18-amd64 78.79% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_model_builder_whereor.go 91.37% <0.00%> (-3.27%) ⬇️
database/gdb/gdb_model_builder_whereor_prefix.go 26.08% <0.00%> (-1.19%) ⬇️
database/gdb/gdb_model_whereor.go 86.66% <0.00%> (-6.20%) ⬇️
database/gdb/gdb_model_whereor_prefix.go 7.14% <0.00%> (-0.55%) ⬇️
os/glog/glog_logger_level.go 76.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@DGuang21 DGuang21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn merged commit f6dbe1a into master May 24, 2023
@gqcn gqcn deleted the enhance/command-enums branch May 24, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants