Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple methods support for object route #2663

Merged
merged 5 commits into from
May 24, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented May 24, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch coverage: 82.66% and project coverage change: +0.08 🎉

Comparison is base (f6dbe1a) 78.81% compared to head (535caea) 78.89%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2663      +/-   ##
==========================================
+ Coverage   78.81%   78.89%   +0.08%     
==========================================
  Files         631      628       -3     
  Lines       51741    51450     -291     
==========================================
- Hits        40778    40591     -187     
+ Misses       8940     8854      -86     
+ Partials     2023     2005      -18     
Flag Coverage Δ
go-1.15-386 78.89% <82.66%> (+0.04%) ⬆️
go-1.15-amd64 ?
go-1.16-386 ?
go-1.16-amd64 ?
go-1.17-386 ?
go-1.17-amd64 ?
go-1.18-386 ?
go-1.18-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp_server_router.go 81.51% <65.51%> (-0.44%) ⬇️
net/ghttp/ghttp_server_openapi.go 81.81% <81.25%> (+0.56%) ⬆️
net/ghttp/ghttp_func.go 65.38% <100.00%> (+2.88%) ⬆️
net/ghttp/ghttp_server_router_serve.go 76.92% <100.00%> (ø)
net/ghttp/ghttp_server_service_handler.go 60.00% <100.00%> (+0.29%) ⬆️
net/ghttp/ghttp_server_service_object.go 87.50% <100.00%> (ø)
net/goai/goai_path.go 73.11% <100.00%> (+5.59%) ⬆️
net/goai/goai_shema.go 73.02% <100.00%> (+1.10%) ⬆️
net/goai/goai_shemas.go 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn merged commit 368312c into master May 24, 2023
@gqcn gqcn deleted the feature/multi-methods-support-for-bind-route branch May 24, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants