Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix : when using otel, calling gclient *Raw methods may result in null pointer exceptions #2697

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

hanqian200705
Copy link
Contributor

bugfix : when using otel, calling gclient *Raw methods may result in null pointer exceptions。
image

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2ece368) 78.88% compared to head (8fd619f) 78.89%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2697   +/-   ##
=======================================
  Coverage   78.88%   78.89%           
=======================================
  Files         632      632           
  Lines       51872    51880    +8     
=======================================
+ Hits        40918    40929   +11     
+ Misses       8928     8925    -3     
  Partials     2026     2026           
Flag Coverage Δ
go-1.15-386 78.93% <100.00%> (+0.03%) ⬆️
go-1.15-amd64 78.90% <100.00%> (+0.02%) ⬆️
go-1.16-386 78.88% <100.00%> (?)
go-1.16-amd64 78.92% <100.00%> (?)
go-1.17-386 78.89% <100.00%> (-0.02%) ⬇️
go-1.17-amd64 78.91% <100.00%> (-0.01%) ⬇️
go-1.18-386 78.81% <100.00%> (-0.03%) ⬇️
go-1.18-amd64 78.84% <100.00%> (+0.02%) ⬆️
go-1.19-386 78.91% <100.00%> (+<0.01%) ⬆️
go-1.19-amd64 78.90% <100.00%> (-0.02%) ⬇️
go-1.20-386 78.86% <100.00%> (?)
go-1.20-amd64 78.92% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/gclient/gclient_tracing_tracer.go 63.20% <100.00%> (+3.00%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 15eaac3 into gogf:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants