Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add default client instance for contrib/sdk/httpclient #2814

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

windvalley
Copy link
Contributor

@windvalley windvalley commented Jul 31, 2023

用户在使用sdk/httpclient的时候可能忽略或忘记定制http客户端, 此时应该为其提供一个默认的http客户端实例(gclient.New()), 否则程序将会异常退出.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (e0e0043) to head (e567ba9).
Report is 361 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
- Coverage   79.22%   79.21%   -0.02%     
==========================================
  Files         633      630       -3     
  Lines       52242    51903     -339     
==========================================
- Hits        41391    41117     -274     
+ Misses       8808     8760      -48     
+ Partials     2043     2026      -17     
Flag Coverage Δ
go-1.15-386 79.18% <ø> (-0.03%) ⬇️
go-1.15-amd64 ?
go-1.16-386 ?
go-1.16-amd64 79.19% <ø> (-0.03%) ⬇️
go-1.17-386 ?
go-1.17-amd64 ?
go-1.18-386 ?
go-1.18-amd64 ?
go-1.19-386 ?
go-1.19-amd64 79.18% <ø> (-0.04%) ⬇️
go-1.20-386 79.19% <ø> (+<0.01%) ⬆️
go-1.20-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn
Copy link
Member

gqcn commented Aug 1, 2023

@windvalley Thanks for your contribution!

@gqcn gqcn merged commit c517851 into gogf:master Aug 1, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants