Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gconv custom converter feature. #2828

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Add gconv custom converter feature. #2828

merged 6 commits into from
Aug 7, 2023

Conversation

joy999
Copy link
Contributor

@joy999 joy999 commented Aug 2, 2023

Please have a check and help improve it.

@houseme houseme requested review from gqcn and hailaz August 2, 2023 12:54
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage: 74.64% and project coverage change: -0.06% ⚠️

Comparison is base (7961757) 79.16% compared to head (6d249fd) 79.10%.
Report is 3 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2828      +/-   ##
==========================================
- Coverage   79.16%   79.10%   -0.06%     
==========================================
  Files         633      634       +1     
  Lines       52338    52409      +71     
==========================================
+ Hits        41434    41460      +26     
- Misses       8843     8881      +38     
- Partials     2061     2068       +7     
Flag Coverage Δ
go-1.18-386 79.18% <74.64%> (-0.07%) ⬇️
go-1.18-amd64 79.19% <74.64%> (-0.03%) ⬇️
go-1.19-386 79.08% <74.64%> (-0.03%) ⬇️
go-1.19-amd64 79.04% <74.64%> (-0.08%) ⬇️
go-1.20-386 79.16% <74.64%> (-0.07%) ⬇️
go-1.20-amd64 79.17% <74.64%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
util/gconv/gconv_converter.go 72.30% <72.30%> (ø)
util/gconv/gconv_struct.go 82.62% <100.00%> (+0.22%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joy999 joy999 requested a review from houseme August 3, 2023 11:23
@gqcn
Copy link
Member

gqcn commented Aug 3, 2023

@joy999 Awesome! But it needs some time processing code review.

@gqcn gqcn added the awesome It's awesome! We keep watching. label Aug 3, 2023
@joy999 joy999 requested a review from houseme August 3, 2023 13:34
@gqcn gqcn merged commit 932f8c4 into gogf:master Aug 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome It's awesome! We keep watching.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants