Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in SliceMap/Maps for package gconv when nil value in map of slice item #2857

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Aug 10, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 54.54% and project coverage change: -0.01% ⚠️

Comparison is base (243fe73) 79.17% compared to head (792e488) 79.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2857      +/-   ##
==========================================
- Coverage   79.17%   79.16%   -0.01%     
==========================================
  Files         634      634              
  Lines       52423    52428       +5     
==========================================
+ Hits        41506    41507       +1     
- Misses       8855     8858       +3     
- Partials     2062     2063       +1     
Flag Coverage Δ
go-1.18-386 79.22% <54.54%> (-0.03%) ⬇️
go-1.18-amd64 79.27% <54.54%> (+0.05%) ⬆️
go-1.19-386 79.15% <54.54%> (+0.01%) ⬆️
go-1.19-amd64 79.15% <54.54%> (+0.07%) ⬆️
go-1.20-386 79.23% <54.54%> (+0.03%) ⬆️
go-1.20-amd64 79.23% <54.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
util/gconv/gconv_map.go 96.00% <54.54%> (-1.15%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit 4020eb9 into master Aug 10, 2023
18 checks passed
@gqcn gqcn deleted the fix/gconv-maps-nil-map-value branch August 10, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants