Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty map or struct convert to another map will return error. #2863

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

joy999
Copy link
Contributor

@joy999 joy999 commented Aug 11, 2023

Fix empty map or struct convert to another map will return error.
After fixed, it will return an empty map, not a nil or error.

@joy999 joy999 requested a review from gqcn August 11, 2023 15:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ea6a773) 79.15% compared to head (e5b2ddd) 79.16%.
Report is 3 commits behind head on master.

❗ Current head e5b2ddd differs from pull request most recent head 5c6b1f8. Consider uploading reports for the commit 5c6b1f8 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2863   +/-   ##
=======================================
  Coverage   79.15%   79.16%           
=======================================
  Files         634      634           
  Lines       52430    52431    +1     
=======================================
+ Hits        41502    41507    +5     
+ Misses       8864     8861    -3     
+ Partials     2064     2063    -1     
Flag Coverage Δ
go-1.18-386 79.23% <100.00%> (+0.03%) ⬆️
go-1.18-amd64 79.25% <100.00%> (+0.05%) ⬆️
go-1.19-386 79.12% <100.00%> (+0.06%) ⬆️
go-1.19-amd64 79.13% <100.00%> (+0.02%) ⬆️
go-1.20-386 79.19% <100.00%> (-0.03%) ⬇️
go-1.20-amd64 79.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
util/gconv/gconv_map.go 96.01% <100.00%> (+<0.01%) ⬆️
util/gconv/gconv_struct.go 82.62% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit 24ee534 into master Aug 17, 2023
12 of 18 checks passed
@gqcn gqcn deleted the fix/issue-2859 branch August 17, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants