Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve signal listening for package grpcx/ghttp/gproc #2942

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Sep 7, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch coverage: 67.08% and project coverage change: +0.12% 🎉

Comparison is base (74bf1b4) 79.15% compared to head (0b00dfb) 79.27%.
Report is 11 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2942      +/-   ##
==========================================
+ Coverage   79.15%   79.27%   +0.12%     
==========================================
  Files         638      639       +1     
  Lines       52570    52700     +130     
==========================================
+ Hits        41611    41779     +168     
+ Misses       8892     8852      -40     
- Partials     2067     2069       +2     
Flag Coverage Δ
go-1.18-386 79.37% <67.08%> (+0.18%) ⬆️
go-1.18-amd64 79.35% <67.08%> (+0.14%) ⬆️
go-1.19-386 79.25% <67.08%> (+0.15%) ⬆️
go-1.19-amd64 79.21% <67.08%> (+0.10%) ⬆️
go-1.20-386 79.34% <67.08%> (+0.11%) ⬆️
go-1.20-amd64 79.35% <67.08%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
container/gmap/gmap_hash_str_any_map.go 98.20% <ø> (ø)
contrib/rpc/grpcx/grpcx_grpc_server.go 38.34% <0.00%> (+2.27%) ⬆️
database/gdb/gdb.go 81.49% <ø> (+13.15%) ⬆️
database/gdb/gdb_result.go 36.00% <ø> (+3.85%) ⬆️
internal/instance/instance.go 100.00% <ø> (ø)
net/ghttp/ghttp_server_admin.go 17.24% <0.00%> (+1.36%) ⬆️
net/ghttp/ghttp_server_admin_process.go 0.00% <0.00%> (ø)
os/gcache/gcache.go 96.77% <ø> (ø)
os/gtime/gtime.go 86.93% <ø> (ø)
text/gregex/gregex_cache.go 100.00% <ø> (ø)
... and 25 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit 1582714 into master Sep 11, 2023
18 checks passed
@gqcn gqcn deleted the enhance/signal-listen branch September 11, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants