-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve example cases for package gi18n #2970
Conversation
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2970 +/- ##
==========================================
+ Coverage 79.09% 79.24% +0.14%
==========================================
Files 643 643
Lines 52754 52754
==========================================
+ Hits 41727 41806 +79
+ Misses 8945 8867 -78
+ Partials 2082 2081 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@hailaz 单例和示例代码没必要严格解耦,特别是示例的代码是你的代码写什么样别人看到就是什么样,假如你做了封装了其实别人看示例代码会很懵的。比如: |
那就统一示例吧,现在是有些返回信息是指定了i18n的信息,有些返回了默认信息。然后这个i18n的目录文件其实和testdata中的i18n是重复的,而且本该放到testdata中。 |
Let’s unify the examples. Now some of the returned information specifies i18n information, and some return default information. Then this i18n directory file is actually duplicated with the i18n in testdata, and should have been placed in testdata. |
gvalid的单测和示例混着部分隐式使用i18n的情况,而且这个i18n来自
util/gvalid/i18n
文件夹,不太规范。现在移除
util/gvalid/i18n
文件夹使用util/gvalid/testdata/i18n
中的数据,两个文件夹的内容基本重复。