Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve address configuration for grpc server #2982

Merged
merged 13 commits into from
Sep 27, 2023
Merged

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Sep 25, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (569cbb0) 77.28% compared to head (e39115e) 77.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2982      +/-   ##
==========================================
+ Coverage   77.28%   77.38%   +0.10%     
==========================================
  Files         645      645              
  Lines       54287    54305      +18     
==========================================
+ Hits        41955    42024      +69     
+ Misses      10226    10173      -53     
- Partials     2106     2108       +2     
Flag Coverage Δ
go-1.18-386 77.44% <64.51%> (?)
go-1.18-amd64 77.46% <64.51%> (+0.17%) ⬆️
go-1.19-386 77.34% <64.51%> (+0.08%) ⬆️
go-1.19-amd64 77.35% <64.51%> (+0.10%) ⬆️
go-1.20-386 77.45% <64.51%> (?)
go-1.20-amd64 77.44% <64.51%> (+0.13%) ⬆️
go-1.21-386 77.46% <64.51%> (+0.14%) ⬆️
go-1.21-amd64 77.42% <64.51%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contrib/rpc/grpcx/grpcx_grpc_server_config.go 61.53% <ø> (ø)
os/gproc/gproc_signal.go 50.63% <72.22%> (+3.66%) ⬆️
contrib/rpc/grpcx/grpcx_grpc_server.go 62.55% <53.84%> (+24.20%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit 3004033 into master Sep 27, 2023
23 of 24 checks passed
@gqcn gqcn deleted the enhance/grpc-server-address branch September 27, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants