Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve specification version #2987

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

houseme
Copy link
Member

@houseme houseme commented Sep 26, 2023

No description provided.

@houseme houseme requested a review from gqcn September 26, 2023 12:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (df92c48) 79.34% compared to head (cf573d0) 77.30%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2987      +/-   ##
==========================================
- Coverage   79.34%   77.30%   -2.04%     
==========================================
  Files         636      645       +9     
  Lines       52457    54287    +1830     
==========================================
+ Hits        41620    41966     +346     
- Misses       8780    10217    +1437     
- Partials     2057     2104      +47     
Flag Coverage Δ
go-1.18-386 77.34% <54.58%> (?)
go-1.18-amd64 77.35% <54.58%> (-1.97%) ⬇️
go-1.19-386 77.25% <54.58%> (?)
go-1.19-amd64 77.28% <54.58%> (?)
go-1.20-386 77.30% <54.58%> (?)
go-1.20-amd64 77.34% <54.58%> (?)
go-1.21-386 77.31% <54.58%> (-1.94%) ⬇️
go-1.21-amd64 77.29% <52.98%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
net/ghttp/ghttp.go 50.00% <ø> (-50.00%) ⬇️
net/ghttp/ghttp_request_middleware.go 56.80% <100.00%> (-26.09%) ⬇️
net/ghttp/ghttp_server_openapi.go 81.81% <100.00%> (ø)
os/gstructs/gstructs_field_tag.go 100.00% <100.00%> (ø)
net/ghttp/ghttp_request_param_request.go 77.67% <91.11%> (-13.51%) ⬇️
contrib/config/consul/consul.go 43.61% <43.61%> (ø)
net/ghttp/ghttp_server_service_handler.go 62.05% <46.72%> (-2.19%) ⬇️

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houseme houseme requested a review from hailaz September 26, 2023 14:01
@gqcn gqcn merged commit 569cbb0 into master Sep 26, 2023
24 checks passed
@gqcn gqcn deleted the fix/fix/upgrade-polaris-version-specification branch September 26, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants