Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/gf): add command gf doc for local documentation #3634

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Jun 6, 2024

下载pages.goframe.org到本地运行

GOPROXY=direct GOSUMDB=off go install github.com/gogf/gf/cmd/gf/v2@feat/docrun
gf doc

@gqcn
Copy link
Member

gqcn commented Jun 11, 2024

@hailaz 这个下载全量的pages文档有些慢,得161MB。既然要去github下载pages文档,那为什么不直接去访问pages呢,单独访问pages还不需要全量下载?

@gqcn gqcn changed the title cmd/gf: 新增gf doc命令 cmd/gf: add command gf doc Jun 11, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@hailaz This download of the full pages document is a bit slow, it is 161MB. Since you are going to github to download the pages document, why not directly access pages? Accessing pages alone does not require full downloading?

@hailaz
Copy link
Member Author

hailaz commented Jun 12, 2024

@hailaz 这个下载全量的pages文档有些慢,得161MB。既然要去github下载pages文档,那为什么不直接去访问pages呢,单独访问pages还不需要全量下载?

强哥有所不知,并不是所有人都有稳定的梯子,要不是有goproxy,有的人代码都难下载。
现在官网在新加坡,已经拦截掉一些人了,pages访问也受墙影响,最后http的访问比pdf好。
我新加了个proxy参数,可以用代理来下载整个文档。
加这样一个功能并没有坏处吧,只有第一次下载费时间,第二次就直接启动了。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@hailaz This download of the full pages document is a bit slow, 161MB. Since you are going to github to download the pages document, why not directly access pages? Accessing pages alone does not require full downloading?

What Brother Qiang doesn’t know is that not everyone has a stable ladder. If it weren’t for goproxy, it would be difficult for some people to download the code.
Now that the official website is in Singapore, some people have been blocked. Pages access is also affected by the wall. Finally, http access is better than pdf.
I added a new proxy parameter, which can use a proxy to download the entire document.
There is no harm in adding such a function. It only takes time to download the first time, but it starts directly the second time.

@hailaz hailaz requested a review from gqcn June 12, 2024 03:43
Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn merged commit dea0ffc into master Jun 12, 2024
23 checks passed
@gqcn gqcn deleted the feat/docrun branch June 12, 2024 13:29
@gqcn gqcn changed the title cmd/gf: add command gf doc feat(cmd/gf): add command gf doc for local documentation Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants