fix(net/ghttp/): fix the issue of using application/octet stream to upload large files causing excessive memory and crashing #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam would copy the body and cause excessive memory usage
gqcn
requested changes
Jul 29, 2024
| @@ -229,6 +229,12 @@ func (r *Request) parseBody() { | |||
| if r.parsedBody { | |||
| return | |||
| } | |||
|
|
|||
| // If it's binary data, it does not need to be parsed. | |||
| if contentType := r.Header.Get("Content-Type"); contentType == "" || gstr.Contains(contentType, "octet-stream") { | |||
There was a problem hiding this comment.
- condition
contentType == ""might be removed? - missing associated unit testing case for the changes.
|
@TotoroZuo Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this problem is that when creating RouterFunc initializes the request, it calls the MakeBodyRepeatableRead method to write the r.body to memory and change it to Repeatable. However, pure binary files do not require formatting of either the form or the body
So the solution is to detect the application/octet stream type and exit it early in the formatted form and body methods
Fixes #3692