Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contrib/config/nacos): add OnChange callbacks configuration support #3858

Closed
wants to merge 23 commits into from
Closed

feat(contrib/config/nacos): add OnChange callbacks configuration support #3858

wants to merge 23 commits into from

Conversation

LanceAdd
Copy link
Contributor

Allows custom actions after a remote profile update

gqcn
gqcn requested changes Oct 16, 2024
View reviewed changes
contrib/config/nacos/nacos.go Outdated Show resolved Hide resolved
gqcn
gqcn requested changes Oct 16, 2024
View reviewed changes
contrib/config/nacos/nacos.go Outdated Show resolved Hide resolved
@gqcn gqcn changed the title feat(contrib/nacos): Allows custom actions after a remote profile update feat(contrib/config/nacos): add OnChange callbacks configuration support Oct 16, 2024
gqcn
gqcn requested changes Oct 24, 2024
View reviewed changes
contrib/config/nacos/nacos.go Outdated Show resolved Hide resolved
@gqcn gqcn added the ready to merge Used in PR, which means this PR is reviewed. label Nov 11, 2024
@gqcn gqcn added this to the v2.9.x milestone Nov 11, 2024
houseme
houseme reviewed Dec 1, 2024
View reviewed changes
contrib/config/nacos/nacos_test.go
"github.com/gogf/gf/v2/frame/g"
"github.com/gogf/gf/v2/os/gctx"
"github.com/gogf/gf/v2/test/gtest"
"github.com/gogf/gf/v2/util/guid"
"github.com/nacos-group/nacos-sdk-go/v2/common/constant"
"github.com/nacos-group/nacos-sdk-go/v2/vo"
"net/url"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个引入还原一下

@gqcn
Copy link
Member

gqcn commented Dec 7, 2024 •
edited by houseme
Loading

@LanceAdd 请更新合并master分支，处理一下文件冲突,感谢

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@LanceAdd Please handle the file conflict.

@houseme
Copy link
Member

houseme commented Dec 7, 2024

如何处理 import 可以看下 #4010

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

How to handle import can be seen in #4010

@LanceAdd
Copy link
Contributor Author

如何处理 import 可以看下 #4010

好的，我学习下

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

How to handle import can be seen in #4010

Okay, I'll study

@LanceAdd
Merge branch 'gogf:master' into master
ede6e55
@LanceAdd
[lanceadd]The two PRs gogf#4025 and gogf#4029 made 'v.17.0'->'v.18.0'…
53918f6 
…->'v1.17.0' to the version number of 'github.com/fatih/color', it seems that 'v.18.0' should be used
@houseme houseme requested a review from gqcn December 11, 2024 03:24
@houseme
Copy link
Member

houseme commented Dec 11, 2024

@LanceAdd 需要您在自己分支提交一次commit，会自动格式化 contrib/config/nacos/nacos.go 和 contrib/config/nacos/nacos_test.go ,谢谢

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@LanceAdd You need to submit a commit in your own branch, and contrib/config/nacos/nacos.go and contrib/config/nacos/nacos_test.go will be automatically formatted, thank you

@LanceAdd
Copy link
Contributor Author

@LanceAdd 需要您在自己分支提交一次commit，会自动格式化 contrib/config/nacos/nacos.go 和 contrib/config/nacos/nacos_test.go ,谢谢

image
可以帮忙看下这个问题吗，是我哪里没有配置吗还是因为我偷懒用了master分支的原因，有被自己菜到

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@LanceAdd You need to submit a commit in your own branch, and contrib/config/nacos/nacos.go and contrib/config/nacos/nacos_test.go will be automatically formatted, thank you

image
Can you help me look into this problem? Is it because I don’t have the configuration somewhere? Or is it because I was lazy and used the master branch? Have I been fooled by myself?

@LanceAdd
Copy link
Contributor Author

LanceAdd commented Dec 12, 2024 •
edited
Loading

因为使用master分支的原因导致gci无法正常使用，使用新的分支处理该PR 新的PR：#4038 当前这个PR先关闭了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Because gci cannot be used normally due to the use of the master branch, use a new branch to process the PR.

@LanceAdd LanceAdd closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseme houseme houseme left review comments

@gqcn gqcn Awaiting requested review from gqcn

Assignees
No one assigned
Labels
ready to merge Used in PR, which means this PR is reviewed.
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LanceAdd @gqcn @Issues-translate-bot @houseme