-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(net/ghttp): occasional ci failed by unit testing cases using gctp.GetFreePort
#3982
Conversation
….GetFreePort in package ghttp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议:
代码一致性:
确保代码库中的命名约定一致。例如,gracefulserver 与 gracefulServer。
错误处理:
改进如 getNetListener 等函数中的错误处理,以提供更详细和用户友好的错误消息。
文档:
为新包及其方法添加更多注释和文档,以提高可读性和可维护性。
你这怎么像AI的评论 。 |
How do you look like an AI comment? |
统一名称还是可以的,注释可以滞后 |
It is still possible to unify the name, but the comments can lag behind |
gctp.GetFreePort
gctp.GetFreePort
@houseme 好啦,再看看呢。如果还有问题请在具体代码行号标注一下哈。 |
@houseme Okay, let’s take a look. If you still have any questions, please mark the specific code line number. |
- Removed the `pull_request` trigger from the `golangci-lint.yml` workflow.
No description provided.