Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort import for plugin outputs #741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sbalabanov
Copy link

If generatePlugin() function is used to generate Go code, imports are not ordered. Because imports are technically a map inside a Generator and iteration order over a map is not deterministic, it results to import ordering in the resulting generated file be non-deterministic too.
This creates a problem for build tools that extensively use remote cache based on hashes of input targets, like Bazel.
The change adds sorting through AST. Ideally, generatePlugin() function should reuse the code for Generate() function, that already has this sorting among other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants