[WIP] GPG signature verification #3127
Conversation
|
@sapk Make sure you are not doing double work here. @bkcsoft indicates two weeks ago to be working on this too: #2321 (comment) |
|
I have not started on that one yet, and this one does verification which
mine wouldn't (only stupidly show that it had been signed)
WRT people working on things. PR fast, mark it WIP. If no PR for a feature
exists, no one is working on it 😆
|
|
@bkcsoft Totally of topic, but it would be nice to have people link to the branch where they are working on it (I know it's visible, but not clickable), so that people could file PRs to that feature's branch to contribute :) Just imagining an ideal world of decentralized collaboration ;) Good to see you are also actively maintaining this project next to Unknwon! |
|
@stevenroose I had not noticed that they were not clickable 😆 Yes, link to branch would be nice (even though the PR will update when the branch is pushed to...) |
|
@sapk still working on this? I found OpenPGP.js and realized that verification could be done in the frontend to off-load the backend (not that it requires off-loading, but nice to keep the load in the frontend if it's possible 😆 ) Thoughts? |
|
I didn't tackle the part of the verification and I didn't have time to go further but i will re-put myself on it on the next days. Doing it in the front-end could be done easely. It just need the API to get the user public key from gogs like https://developer.github.com/v3/users/keys/. On the other hand, i don't thinks it would be too much work for the backen to do it. I have to think about it but at first at will implement the API because in both case they will be needed (or at least usefull) |
sapk
force-pushed
the
implement-gpg-keys-api
branch
from
58827bf to
5ba9aa8
Compare
|
any news ? :) |
|
sadly no time yet :-( |
sapk
force-pushed
the
implement-gpg-keys-api
branch
from
5ba9aa8 to
1fae611
Compare
sapk
force-pushed
the
implement-gpg-keys-api
branch
from
1fae611 to
1c4bf7a
Compare
|
?? |
|
@unknwon why did you close this? |
|
I'd kindly invite you to join the Gitea community where a more open approach to community-driven software development is used :) |
* comment backport test since the test reference many changes * fix missing drone test on release/* * remove test coverage on release/*
ghost
mentioned this pull request
I start to implement API and extracting information for the git cli via gogs/git-module#13. It may need to add some little parts to the gogits/go-gogs-client to be more specific to GPG key api.
Related to #2321 and #2981
Branch : sapk/gogs:implement-gpg-keys-api