netutil: allow using * to match any hostname
#7111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuhan005
approved these changes
Jul 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #7111 +/- ##
=======================================
Coverage 11.76% 11.76%
=======================================
Files 106 106
Lines 13619 13619
=======================================
Hits 1602 1602
Misses 11812 11812
Partials 205 205 |
unknwon
changed the title
* to match any hostname
unknwon
added a commit
that referenced
this pull request
Aug 2, 2022
# Conflicts: # internal/netutil/netutil_test.go
|
The 0.12.10 has been released that includes the patch of the reported issue. |
dna2github
pushed a commit
to dna2fork/gogs
that referenced
this pull request
May 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Allow using
*as an escape hatch for all local network address.Link to the issue: #7048 (comment)
Checklist