feat: remove containerd service dependency #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiki-high
changed the title
Desiki-high
force-pushed
the
feat-remove-containerd
branch
from
6fd1bd0
to
ea70c00
Compare
Desiki-high
changed the title
imeoer
reviewed
May 24, 2023
imeoer
reviewed
May 24, 2023
Desiki-high
force-pushed
the
feat-remove-containerd
branch
from
ea70c00
to
e4e608d
Compare
|
@imeoer Please review again. The next work is add boltdb to manage the layer caches. |
Signed-off-by: Yadong <ding_yadong@foxmail.com>
We don't need containerd service local. We add the new opt workdir used by content store. Signed-off-by: Yadong <ding_yadong@foxmail.com>
imeoer
reviewed
May 25, 2023
imeoer
reviewed
May 25, 2023
Desiki-high
force-pushed
the
feat-remove-containerd
branch
from
ac5699d
to
2528bc6
Compare
imeoer
approved these changes
May 25, 2023
Remove containerd service dependency for acceld. We use LabeledStore to manage image layers and descriptors. Signed-off-by: Yadong <ding_yadong@foxmail.com>
Signed-off-by: Yadong <ding_yadong@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceld depend on local containerd service, we should replace it by create content store by containerd pkg.
We use github.com/containerd/containerd/content/local to remove containerd service dependency.
Break Change:
resolve #137.