feat: use lease to manage local cache for gc #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiki-high
force-pushed
the
feat-lm
branch
2 times, most recently
from
1403831
to
2a58d93
Compare
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
We can use leaseManager to keep the content blob cache. LeaseManager will create lease of eache content blob in fetch and push.We will update the time of each blob used time in lease. Save in labels. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
GC will delete content blobs until local cache size less than threshold. GC prioritizes the removal of recently unused blob. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now acceld's
GarbageCollectwill clear all caches when content size is over the threshold. We should use the lease to choose which content blob should be reserved. TheupdatedAtcan help us choose.Changes:
updatedAtto lease bucket (labels).updatedAtwhen pushing blob.updatedAt.Reference: #141.