feat: Wrap content to support cache #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiki-high
reviewed
Aug 8, 2023
imeoer
reviewed
Aug 9, 2023
|
Please split the PR into multiple commits logically, and also add commit messages explaining why and how. |
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
from
ecf8c75
to
490b91e
Compare
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
3 times, most recently
from
6d20d39
to
387c86f
Compare
imeoer
reviewed
Aug 18, 2023
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
from
387c86f
to
9ce659d
Compare
imeoer
reviewed
Aug 21, 2023
imeoer
reviewed
Aug 21, 2023
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
from
9ce659d
to
b55f484
Compare
imeoer
reviewed
Aug 22, 2023
We can use LRU in content store and wrap some methods to provides remote cache. Here Info, Update, ReaderAt, Walk methods were wraped and they can get, update, and do other operations in LRU cache. Also, we can configure whether to enable cache or not with cache_tag_suffix.And we can config cache size. Signed-off-by: breezeTuT <y_q_email@163.com>
Here we can pull remote cache, use remote cache for conversion, and push the updated cache back to the remote. When updating, we follow a upper->lower order. Signed-off-by: breezeTuT <y_q_email@163.com>
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
from
b55f484
to
f808592
Compare
imeoer
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add remote cache of remote registry.
Changes:
Ref: #7