Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: add concurrent test #173

Merged
merged 2 commits into from
Aug 25, 2023
Merged

gha: add concurrent test #173

merged 2 commits into from
Aug 25, 2023

Conversation

Desiki-high
Copy link
Collaborator

@Desiki-high Desiki-high commented Aug 16, 2023

Add concurrent test for converting images.

  • Test the same image conversion tasks in high concurrent.
  • Test the different image conversion tasks in high concurrent.

Ref: #174

@Desiki-high Desiki-high force-pushed the ci-concurrent branch 9 times, most recently from 25d2301 to a489bbb Compare August 17, 2023 09:53
@Desiki-high
Copy link
Collaborator Author

Desiki-high commented Aug 18, 2023

Please don't merge until other pr fixes the error when working in concurrent.

@imeoer
Copy link
Collaborator

imeoer commented Aug 21, 2023

It seems still have a concurrent race issue in this test after merging #172 and retired the test.

@Desiki-high
Copy link
Collaborator Author

It seems still have a concurrent race issue in this test after merging #172 and retired the test.

Yes, gc still clears blobs which will be used by converting tasks, I will try other ways to fix it. Keep this pr unmerged.

@Desiki-high Desiki-high force-pushed the ci-concurrent branch 2 times, most recently from 9e3438a to f8c0e50 Compare August 24, 2023 07:34
Test the same image in high concurrent.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Test the different images in high concurrent.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high
Copy link
Collaborator Author

Since #175 was merged,this pr works well now.

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the test script.

@imeoer imeoer merged commit 6ce9a79 into goharbor:main Aug 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants