export converter as a usable package #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
imeoer
commented
Dec 20, 2022
•
imeoer
commented
imeoer
force-pushed
the
export-converter
branch
6 times, most recently
from
2bd88f2
to
d406d89
Compare
So that we can import the `pkg/converter` package into other projects to integrate the image conversion ability. This patch is no logic changes. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
Simplify the content.Provider interface, so that it can be implemented by other implementations. This patch is no logic changes. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
force-pushed
the
export-converter
branch
from
d406d89
to
ee697f3
Compare
So that we can convert `localhost:5000/busybox` reference (with no tag) to `localhost:5000/busybox:latest` (tagged) automatically. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
added a commit
to imeoer/image-service
that referenced
this pull request
Dec 23, 2022
Refactor converter workflow using the converter package in acceld project: goharbor/acceleration-service#84 This allows nydusify to reuse acceld/snapshotter codes and to convert layers concurrently, as well as to support the zran conversion later. This patch causes nydusify to rely on the containerd daemon service, we will remove this restriction in the next commit. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
changed the title
liubogithub
approved these changes
Dec 24, 2022
| if err != nil { | ||
| return errors.Wrap(err, "convert image") | ||
| } | ||
|
|
There was a problem hiding this comment.
We need to migrate to the new artifact reference spec, the annotations defined here are unnecessary anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.