Fixed the registry info issue #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
|
ready for review |
|
The flow should be consistent across all cli calls by name or id. If you take a look into the api spec, you see many commands that support name also support id. As we are calling the rest api it makes sense to have the same flow? What do you think? |
|
most of the commands support name. so we can consistently follow the cli calls by name. |
qcserestipy
pushed a commit
to qcserestipy/harbor-cli
that referenced
this pull request
Dec 22, 2024
* fixed the issue#224 Signed-off-by: ALTHAF <althafasharaf02@gmail.com> * fixed the issue#224 Signed-off-by: ALTHAF <althafasharaf02@gmail.com> * some modification in registry Signed-off-by: ALTHAF <althafasharaf02@gmail.com> --------- Signed-off-by: ALTHAF <althafasharaf02@gmail.com> Signed-off-by: Patrick Eschenbach <patrickeschenbach96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #224
Now we can view the registry by giving the registry name