Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Harbor architecture describes a Proxy layer, but the Helm chart doesn't allow for that layer to be provided by anything other than nginx, with either an nginx object being created if the expose type is "ingress", or nginx itself being deployed if set to anything else.
I would like to extend the functionality to be able to 'bring my own proxy', in my case I want to use Contour with HTTPproxy objects. Rather than implement support for this in Harbor, it is easier simply to implement and expose option of 'external' where the chart can assume the proxy deployment is handled elsewhere. In this case no nginx deployment or object creation is triggered by the chart.