Create unit tests for Core #1787
Conversation
cvegagimenez
force-pushed
the
feat/add-core-tests
branch
2 times, most recently
from
6e91857
to
42000ea
Compare
- Migrate `go test` to `helm unittest` - Migrate Trivy existing unit tests to `helm unittest` - Add unit tests for Core Signed-off-by: Carlos Vega <carlos.vega@dynatrace.com>
cvegagimenez
force-pushed
the
feat/add-core-tests
branch
from
42000ea
to
1da7ed5
Compare
| path: data.GC_TIME_WINDOW_HOURS | ||
| value: "2" | ||
|
|
||
| - it: GcTimeWindowHours |
There was a problem hiding this comment.
line 105, GcTimeWindowHours may need to be changed to a different value, as it is used in line 95 and not related to its context.
| path: data.CACHE_EXPIRE_HOURS | ||
| value: "3" | ||
|
|
||
| - it: CuotaUpdate |
| - it: PodAnnotations | ||
| set: | ||
| core: | ||
| podAnnotations: | ||
| test.annotation: test-annotation | ||
| template: templates/core/core-dpl.yaml | ||
| asserts: | ||
| - equal: | ||
| path: spec.template.metadata.annotations["test.annotation"] | ||
| value: test-annotation |
There was a problem hiding this comment.
line 26 - line35 is a duplicate of line 15 - line24
There was a problem hiding this comment.
Removed the duplicated tests and renamed the wrong ones.
test/unittest/core_secret_test.yaml
Outdated
| - notExists: | ||
| path: data.HARBOR_ADMIN_PASSWORD | ||
|
|
||
| - it: ExistingDBSecret |
There was a problem hiding this comment.
maybe change this ExistingDBSecret to ExistingExternalDBSecret?
test/unittest/core_svc_test.yaml
Outdated
| - notExists: | ||
| path: spec.type | ||
|
|
||
| - it: ExposeTLSEnabled |
There was a problem hiding this comment.
Since ExposeTLSEnabled can be misunderstood as expose.tls.enabled, maybe change it to InternalTLSEnabled?
test/unittest/core_svc_test.yaml
Outdated
| path: spec.ports[0].name | ||
| value: https-web | ||
|
|
||
| - it: ExposeTLSDisabled |
There was a problem hiding this comment.
Since ExposeTLSDisabled can be misunderstood as expose.tls.enabled, maybe change it to InternalTLSDisabled?
test/unittest/core_tls_test.yaml
Outdated
| registry: | ||
| enabled: false |
There was a problem hiding this comment.
We don't have registry.enabled configuration in values.yaml. Remove it?
- Remove duplicated test PodAnnotations - Rename test ArtifactPullAsyncFlushDuration Signed-off-by: Carlos Vega <carlos.vega@dynatrace.com>
cvegagimenez
force-pushed
the
feat/add-core-tests
branch
from
a87dadb
to
74326ed
Compare
go testtohelm unittesthelm unittest