-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying the action of button "GC NOW" #18692
Labels
Comments
thanks @tostt we could add a tooltip to describe the time window of GC. |
AllForNothing
pushed a commit
to AllForNothing/harbor
that referenced
this issue
May 25, 2023
1.Fixes goharbor#18692 Signed-off-by: AllForNothing <sshijun@vmware.com>
5 tasks
AllForNothing
pushed a commit
to AllForNothing/harbor
that referenced
this issue
May 26, 2023
1.Fixes goharbor#18692 Signed-off-by: AllForNothing <sshijun@vmware.com>
AllForNothing
pushed a commit
to AllForNothing/harbor
that referenced
this issue
May 26, 2023
1.Fixes goharbor#18692 Signed-off-by: AllForNothing <sshijun@vmware.com>
Vad1mo
pushed a commit
that referenced
this issue
May 26, 2023
1.Fixes #18692 Signed-off-by: AllForNothing <sshijun@vmware.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this issue
Jul 8, 2023
1.Fixes goharbor#18692 Signed-off-by: AllForNothing <sshijun@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this issue
Jul 8, 2023
1.Fixes goharbor#18692 Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
It is not obvious that the "GC NOW" button on the "Clean up" page does not free disk space for all images. This is especially disconcerting when Quotas are activated because users can see that there is some disk space still being used, even after GC. This is most obvious when you delete all images in Harbor. I think most new users expect to see 0 bytes used after GC on an empty project.
Describe the solution you'd like
I suggest adding some text next to the "GC NOW" buttton. This text could be "Note : Any garbage collection operation (including the dry run) only covers images that were not uploaded within the previous two hours." This text is directly copied from paragraph Handling Images That Are Still Uploading
In the case CG ignored some images, they could be mentionned in the log with something like "GC ignored the following images : ..."
The text was updated successfully, but these errors were encountered: