Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the permissions of the *.go file from 0755 to 0644 #17919

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

Iceber
Copy link
Contributor

@Iceber Iceber commented Dec 6, 2022

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@Iceber Iceber requested a review from a team as a code owner December 6, 2022 06:00
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #17919 (1921feb) into main (14e4c07) will decrease coverage by 0.82%.
The diff coverage is n/a.

❗ Current head 1921feb differs from pull request most recent head 00189dc. Consider uploading reports for the commit 00189dc to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17919      +/-   ##
==========================================
- Coverage   67.40%   66.58%   -0.82%     
==========================================
  Files         984      999      +15     
  Lines      106990   108145    +1155     
  Branches     2670     2579      -91     
==========================================
- Hits        72113    72010     -103     
- Misses      30999    32175    +1176     
- Partials     3878     3960      +82     
Flag Coverage Δ
unittests 66.58% <ø> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/api/chart_repository.go 34.10% <ø> (ø)
src/pkg/notification/policy/manager.go 42.85% <ø> (-14.07%) ⬇️

... and 209 files with indirect coverage changes

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but can you share what issue you have faced with the original premissions @Iceber ? :) Thanks!

@OrlinVasilev OrlinVasilev added the release-note/update Update or Fix label Dec 6, 2022
@AllForNothing AllForNothing assigned MinerYang and unassigned stonezdj and zyyw Dec 12, 2022
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436
Copy link
Contributor

@Iceber can you help to resolve this conflicts, then let me merge it, thanks.

Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
@Iceber Iceber force-pushed the change_file_permissions branch from 1921feb to 00189dc Compare April 13, 2023 03:43
@Iceber
Copy link
Contributor Author

Iceber commented Apr 13, 2023

@wy65701436 rebased, sorry to make you wait so long

@Iceber Iceber requested a review from wy65701436 April 13, 2023 03:45
@Vad1mo Vad1mo merged commit 3afa525 into goharbor:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants