-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the permissions of the *.go file from 0755 to 0644 #17919
Conversation
Codecov Report
@@ Coverage Diff @@
## main #17919 +/- ##
==========================================
- Coverage 67.40% 66.58% -0.82%
==========================================
Files 984 999 +15
Lines 106990 108145 +1155
Branches 2670 2579 -91
==========================================
- Hits 72113 72010 -103
- Misses 30999 32175 +1176
- Partials 3878 3960 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but can you share what issue you have faced with the original premissions @Iceber ? :) Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Iceber can you help to resolve this conflicts, then let me merge it, thanks. |
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
1921feb
to
00189dc
Compare
@wy65701436 rebased, sorry to make you wait so long |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: