Fix the channel that never receives a value #18139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18139 +/- ##
==========================================
+ Coverage 67.37% 67.41% +0.03%
==========================================
Files 980 984 +4
Lines 106749 107018 +269
Branches 2668 2669 +1
==========================================
+ Hits 71926 72141 +215
- Misses 30960 30996 +36
- Partials 3863 3881 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
It turned out that the code was modified after running the code style check first, so the first item of the squashed commit message is related to the code style, and the second item is the target I want to modify. Now I modify it like this. |
|
It is always pending for lack of labels. |
fix the code with the linter's recommendation by https://github.com/goharbor/harbor/blob/main/CONTRIBUTING.md#develop-build-and-test Signed-off-by: iAklis <chenpinwei@gmail.com>
|
@iAklis congratulations on merging your first PR here :))) welcome to the club:)) |
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
fix the channel that never receives a value fix the code with the linter's recommendation by https://github.com/goharbor/harbor/blob/main/CONTRIBUTING.md#develop-build-and-test Signed-off-by: iAklis <chenpinwei@gmail.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
fix the channel that never receives a value fix the code with the linter's recommendation by https://github.com/goharbor/harbor/blob/main/CONTRIBUTING.md#develop-build-and-test Signed-off-by: iAklis <chenpinwei@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the channel that never receives a value.
Btw, Fix the code with the linter's recommendation by https://github.com/goharbor/harbor/blob/main/CONTRIBUTING.md#develop-build-and-test
Signed-off-by: iAklis chenpinwei@gmail.com
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: