Add retry times for calling CVE data export execution list API #18297

AllForNothing · 2023-03-02T07:34:51Z

1.Fixes #17879
2.Add retry times to avoid endless API calls for CVE data export execution list API
Signed-off-by: AllForNothing sshijun@vmware.com
Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

Well Written Title and Summary of the PR
Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
Accepted the DCO. Commits without the DCO will delay acceptance.
Made sure tests are passing and test coverage is added if needed.
Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

codecov · 2023-03-02T07:38:45Z

Codecov Report

Merging #18297 (ad41525) into main (90db04e) will decrease coverage by 23.23%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##             main   #18297       +/-   ##
===========================================
- Coverage   67.50%   44.27%   -23.23%     
===========================================
  Files         969      232      -737     
  Lines      105685    12808    -92877     
  Branches     2580     2582        +2     
===========================================
- Hits        71340     5671    -65669     
+ Misses      30537     6856    -23681     
+ Partials     3808      281     -3527

Flag	Coverage Δ
unittests	`44.27% <14.28%> (-23.23%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...shared/components/operation/operation.component.ts	`36.60% <14.28%> (-1.33%)`	⬇️
...es/vulnerability/vulnerability-config.component.ts	`58.51% <0.00%> (-4.45%)`	⬇️
src/jobservice/worker/cworker/c_worker.go
src/jobservice/runner/wrapper.go
src/pkg/exporter/js_worker.go
...pkg/notifier/handler/notification/slack_handler.go
src/pkg/task/dao/task.go
src/pkg/reg/adapter/huawei/image_registry.go
src/server/middleware/nydus/nydus.go
src/controller/replication/flow/stage.go
... and 730 more

1.Fixes goharbor#17879 2.Add retry times to avoid endless API calls for CVE data export execution list API Signed-off-by: AllForNothing <sshijun@vmware.com>

chlins

lgtm

…bor#18297) 1.Fixes goharbor#17879 2.Add retry times to avoid endless API calls for CVE data export execution list API Signed-off-by: AllForNothing <sshijun@vmware.com>

Signed-off-by: Kay Yan <kay.yan@daocloud.io> Improve swagger descriptions (without changing security settings) (goharbor#18205) * Improve swagger definitions. References goharbor#15624 Remove chartmuseum test case (goharbor#18267) Harbor deprecates chartmuseum as of v2.8.0 Epic: goharbor#17958 Discussion: goharbor#15057 Signed-off-by: Yang Jiao <jiaoya@vmware.com> Remove chart api (goharbor#18265) * remove chart api from swagger Delete the api path for chart in the swagger Signed-off-by: Wang Yan <wangyan@vmware.com> * Remove chart APIs 1. Remove some chart-related steps for Dockerfile for portal container 2. Remove chart APIs for API center Signed-off-by: AllForNothing <sshijun@vmware.com> --------- Signed-off-by: Wang Yan <wangyan@vmware.com> Signed-off-by: AllForNothing <sshijun@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Sort user and usergroup by most match order (goharbor#18273) fixes goharbor#17859 Signed-off-by: stonezdj <daojunz@vmware.com> Update the replication rule related to the Chartmuseum (goharbor#18274) Update the registry and replication rule related to the Chartmuseum Update replication_policy and registry as Harbor v2.8.0 deprecates chartmuseum. Harbor deprecates chartmuseum as of v2.8.0 Epic: goharbor#17958 Discussion: goharbor#15057 Signed-off-by: Yang Jiao <jiaoya@vmware.com> refactor: refact the webhook API and life process (goharbor#18255) refactor: refact the notification job API and life process 1. Introduce new APIs for webhook jobs management. 2. Refact legacy APIs for backforward compatible. 3. Migrate the webhook jobs process to unified execution/task framework. Closes: goharbor#18210 Signed-off-by: chlins <chenyuzh@vmware.com> Add retry times for calling CVE data export execution list API (goharbor#18297) 1.Fixes goharbor#17879 2.Add retry times to avoid endless API calls for CVE data export execution list API Signed-off-by: AllForNothing <sshijun@vmware.com> Get job log by job_id in worker (goharbor#18261) Get job by job_id in redis Get the last 10MB of data if it exceeds 10MB Signed-off-by: stonezdj <daojunz@vmware.com> Enhance webhook UI (goharbor#18291) 1. Add execution list for a certain webhook policy 2. Add task list for a certain execution Signed-off-by: AllForNothing <sshijun@vmware.com> Update UI for the deprecation of Artifact Hub (goharbor#18303) 1. Update edit-registry page to enable the edition for Artifact Hub 2. Update edit-replication-rule page to enable the edition for rules contain Artifact Hub Signed-off-by: AllForNothing <sshijun@vmware.com> Add logs column for worker datagrid (goharbor#18307) 1. Related back-end PR goharbor#18261 Signed-off-by: AllForNothing <sshijun@vmware.com>

AllForNothing requested a review from a team as a code owner March 2, 2023 07:34

github-actions bot assigned chlins, MinerYang and zyyw Mar 2, 2023

AllForNothing added the release-note/update Update or Fix label Mar 2, 2023

AllForNothing unassigned zyyw, chlins and MinerYang Mar 2, 2023

AllForNothing requested review from chlins and YangJiao0817 March 2, 2023 07:36

AllForNothing self-assigned this Mar 3, 2023

Add retry times for calling CVE data export execution list API

ad41525

1.Fixes goharbor#17879 2.Add retry times to avoid endless API calls for CVE data export execution list API Signed-off-by: AllForNothing <sshijun@vmware.com>

AllForNothing force-pushed the timeout-export branch from 7f60373 to ad41525 Compare March 3, 2023 04:12

YangJiao0817 approved these changes Mar 3, 2023

View reviewed changes

chlins approved these changes Mar 3, 2023

View reviewed changes

AllForNothing merged commit 6f01d74 into goharbor:main Mar 3, 2023

AllForNothing deleted the timeout-export branch March 29, 2023 05:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add retry times for calling CVE data export execution list API #18297

Add retry times for calling CVE data export execution list API #18297

AllForNothing commented Mar 2, 2023 •

edited

Loading

codecov bot commented Mar 2, 2023 •

edited

Loading

chlins left a comment

Add retry times for calling CVE data export execution list API #18297

Add retry times for calling CVE data export execution list API #18297

Conversation

AllForNothing commented Mar 2, 2023 • edited Loading

Comprehensive Summary of your change

Issue being fixed

codecov bot commented Mar 2, 2023 • edited Loading

Codecov Report

chlins left a comment

Choose a reason for hiding this comment

AllForNothing commented Mar 2, 2023 •

edited

Loading

codecov bot commented Mar 2, 2023 •

edited

Loading