Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error bitsize of jobservice reaper scan locks #18487

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Apr 6, 2023

Change the bitSize from 16 to 64 in the jobservice reaper, the 16 is too small when the redis cursor over the max value of int16.

Fixes: #18486

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #18486

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Change the bitSize from 16 to 64 in the jobservice reaper, the 16 is too
small when the redis cursor over the max value of int16.

Fixes: goharbor#18486

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins requested a review from a team as a code owner April 6, 2023 09:45
@chlins chlins added the release-note/update Update or Fix label Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #18487 (e92ca7c) into main (499940a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18487      +/-   ##
==========================================
- Coverage   67.39%   67.36%   -0.04%     
==========================================
  Files         984      984              
  Lines      106980   106980              
  Branches     2670     2670              
==========================================
- Hits        72104    72070      -34     
- Misses      30992    31028      +36     
+ Partials     3884     3882       -2     
Flag Coverage Δ
unittests 67.36% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/jobservice/worker/cworker/reaper.go 43.77% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 5791f0c into goharbor:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobservice worker reaper error for large cursor
5 participants