Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI testcases #18491

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

YangJiao0817
Copy link
Member

  1. Update copy test case to add retries
  2. Updata P2P Preheat test case to waiting
  3. Update the Replication new rule button xpath

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1. Update copy test case to add retries
2. Updata P2P Preheat test case to waiting
3. Update the Replication new rule button xpath

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #18491 (a85c205) into main (5791f0c) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18491      +/-   ##
==========================================
- Coverage   67.40%   67.37%   -0.04%     
==========================================
  Files         984      984              
  Lines      106980   106980              
  Branches     2670     2670              
==========================================
- Hits        72109    72073      -36     
- Misses      30991    31027      +36     
  Partials     3880     3880              
Flag Coverage Δ
unittests 67.37% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit cbf0a86 into goharbor:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants