Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup docker error #18583

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Conversation

YangJiao0817
Copy link
Member

Fix this error[https://github.com/goharbor/harbor/actions/runs/4776991336/jobs/8492390908]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 requested a review from a team as a code owner April 23, 2023 09:30
@YangJiao0817 YangJiao0817 added release-note/infra Infra related changes e.g. release, test, ship etc... area/ci labels Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #18583 (39ec266) into main (dd973b1) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18583      +/-   ##
==========================================
- Coverage   67.41%   67.37%   -0.04%     
==========================================
  Files         984      984              
  Lines      107010   107010              
  Branches     2670     2670              
==========================================
- Hits        72137    72097      -40     
- Misses      30994    31035      +41     
+ Partials     3879     3878       -1     
Flag Coverage Δ
unittests 67.37% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 8229134 into goharbor:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants