Fix message prompt under the header #18613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Fixes goharbor#18601 Signed-off-by: AllForNothing <sshijun@vmware.com>
AllForNothing
added
the
release-note/enhancement
Codecov Report
@@ Coverage Diff @@
## main #18613 +/- ##
==========================================
- Coverage 67.39% 67.36% -0.03%
==========================================
Files 984 984
Lines 107010 107010
Branches 2670 2670
==========================================
- Hits 72116 72089 -27
- Misses 31013 31038 +25
- Partials 3881 3883 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
YangJiao0817
approved these changes
Apr 27, 2023
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
1.Fixes goharbor#18601 Signed-off-by: AllForNothing <sshijun@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the message prompts the mounted on the right page, if the users scroll the page to the bottom, the message will be covered.
Before:
After:
The message prompts are now fixed under the header, it is not scrollable with the page
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: