fix: non-ASCII chars in swagger.yaml #18642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18642 +/- ##
==========================================
+ Coverage 67.37% 67.39% +0.01%
==========================================
Files 984 984
Lines 107029 107029
Branches 2670 2670
==========================================
+ Hits 72112 72127 +15
+ Misses 31035 31021 -14
+ Partials 3882 3881 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There are a `ß` char and some U+ff5c "｜" in the swagger.yaml. The character U+ff5c "｜" could be confused with the ASCII character U+007c "|". Signed-off-by: bin liu <liubin0329@gmail.com>
MinerYang
force-pushed
the
fix/non-ascii-chars
branch
from
7babeca to
66259f8
Compare
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
There are a `ß` char and some U+ff5c "｜" in the swagger.yaml. The character U+ff5c "｜" could be confused with the ASCII character U+007c "|". Signed-off-by: bin liu <liubin0329@gmail.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
There are a
ßchar and some U+ff5c "｜" in the swagger.yaml. The character U+ff5c "｜" could be confused with the ASCII character U+007c "|".Issue being fixed
Fixes #(issue)
Please indicate you've done the following: