-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature export Harbor statistics as Prometheus metric #18679
Feature export Harbor statistics as Prometheus metric #18679
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18679 +/- ##
===========================================
+ Coverage 45.36% 66.27% +20.90%
===========================================
Files 244 1047 +803
Lines 13333 114251 +100918
Branches 2719 2845 +126
===========================================
+ Hits 6049 75722 +69673
- Misses 6983 34400 +27417
- Partials 301 4129 +3828
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b5391d5
to
becc332
Compare
47e5614
to
a60cc15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thank you
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
a60cc15
to
c36292d
Compare
…oharbor/harbor#18679 Signed-off-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com>
…ometheus metric
c36292d
to
6bc12b5
Compare
@Vad1mo since we've reached the FC of v2.10 this week, I just put it into the v2.11 candidate. |
a4c1d63
to
620d00d
Compare
Signed-off-by: Maksym Trofimenko <maksym.trofimenko@gmail.com>
620d00d
to
5c949c1
Compare
@wy65701436 any chance we can get this merged into 2.11? |
@goharbor/all-maintainers, can we get this merged? we have it now running since 1 year in prod across multiple instances and I don't see a reason not merging it. |
@tpoxa Hi, I have several questions about this PR, as follows:
|
This PR exposes the Harbor statistics as Prometheus metric.
The data exposed as metrics are 1:1 taken from the
statistics
API, including the name.New Metrics
Please indicate you've done the following: