Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set tag pull time for proxy cache #18741

Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 26, 2023

fixes #18708

to set the pull time of tag for the first time cache the artifact.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fixes goharbor#18708

to set the pull time of tag for the first time cache the artifact.

Signed-off-by: Wang Yan <wangyan@vmware.com>
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #18741 (b522440) into release-2.8.0 (614683e) will increase coverage by 22.72%.
The diff coverage is 30.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.8.0   #18741       +/-   ##
==================================================
+ Coverage          44.67%   67.39%   +22.72%     
==================================================
  Files                235      984      +749     
  Lines              13089   107016    +93927     
  Branches            2670     2670               
==================================================
+ Hits                5847    72126    +66279     
- Misses              6948    31008    +24060     
- Partials             294     3882     +3588     
Flag Coverage Δ
unittests 67.39% <30.00%> (+22.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/artifact/controller.go 61.85% <0.00%> (ø)
src/controller/proxy/controller.go 14.91% <0.00%> (ø)
src/controller/tag/controller.go 71.42% <66.66%> (ø)

... and 748 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 51dbbef into goharbor:release-2.8.0 May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants